Skip to content

fix: prevent sets from being reported as InPlaceSortAnalysis warnings #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AryazE merged 3 commits into from
Nov 5, 2025
Merged

fix: prevent sets from being reported as InPlaceSortAnalysis warnings #4

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d31b618
fix: prevent sets from being reported as InPlaceSortAnalysis warnings
mohasarc Nov 3, 2025
b891e1b
fix: broaden criteria for listlike objects in InPlaceSortAnalysis
mohasarc Nov 4, 2025
0aba81f
Added tests and renamed a function
AryazE Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dylin/analyses/InPlaceSortAnalysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def pre_call(self, dyn_ast: str, iid: int, function: Callable, pos_args, kw_args
# print(f"{self.analysis_name} pre_call {iid}")
if function is sorted:
# we have to keep the list in memory to keep id(pos_args[0]) stable ? nope!
if hasattr(pos_args[0], "__len__") and len(pos_args[0]) > self.threshold:
if type(pos_args[0]) is list and len(pos_args[0]) > self.threshold:
Copy link
Collaborator

@AryazE AryazE Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if type(pos_args[0]) is list and len(pos_args[0]) > self.threshold:
if hasattr(pos_args[0], "sort") and hasattr(pos_args[0], "__len__") and len(pos_args[0]) > self.threshold:

self.stored_lists[id(pos_args[0])] = {
"iid": iid,
"file_name": dyn_ast,
Expand Down