Skip to content

fix event parsing panic#3657

Merged
jacobcreech merged 7 commits intosolana-foundation:masterfrom
publicqi:fix-event-parsing
Apr 28, 2025
Merged

fix event parsing panic#3657
jacobcreech merged 7 commits intosolana-foundation:masterfrom
publicqi:fix-event-parsing

Conversation

@publicqi
Copy link
Copy Markdown
Contributor

current event parsing regex will panic on the log in the test. a stricter regex pattern is used.

@publicqi publicqi changed the title fix event parsing fix event parsing panic Apr 12, 2025
@publicqi
Copy link
Copy Markdown
Contributor Author

@acheroncrypto please review this

Comment thread client/src/lib.rs
@publicqi publicqi requested a review from nickfrosty April 21, 2025 21:00
@publicqi
Copy link
Copy Markdown
Contributor Author

@nickfrosty ping

@nickfrosty
Copy link
Copy Markdown

the updated regex is good! can you also update the same regex for the js/ts client @publicqi?

@publicqi
Copy link
Copy Markdown
Contributor Author

@nickfrosty this is done. the ts client was pretty outdated. some of the previous rust fixes were not applied, so i rewrote a bit so that the handling logic is the same except for the language

@publicqi
Copy link
Copy Markdown
Contributor Author

@nickfrosty

@publicqi
Copy link
Copy Markdown
Contributor Author

fixed prettier issue. the rest two error also exists in master branch so i'm ignoring

@publicqi
Copy link
Copy Markdown
Contributor Author

ping @nickfrosty

@jacobcreech jacobcreech merged commit 34b6d19 into solana-foundation:master Apr 28, 2025
48 of 52 checks passed
Otter-0x4ka5h pushed a commit to Otter-0x4ka5h/anchor that referenced this pull request Mar 25, 2026
* add test

* stricter regex

* less confusing log

* even stricter regex

* add typescript fix and test

* fix

* prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants