Skip to content

feat(cli): Add MSRV#3873

Merged
jacobcreech merged 7 commits intosolana-foundation:masterfrom
0xIchigo:feat/pin-msrv
Sep 24, 2025
Merged

feat(cli): Add MSRV#3873
jacobcreech merged 7 commits intosolana-foundation:masterfrom
0xIchigo:feat/pin-msrv

Conversation

@0xIchigo
Copy link
Copy Markdown
Contributor

@0xIchigo 0xIchigo commented Aug 22, 2025

This PR aims to add the Minimum Supported Rust Version (MSRV) to the Rust template, since an arbitrary compiler version isn't supported. This resolves #3745

Note: We only pin the host-side toolchain and tests since Solana currently uses a different forked version of Rust

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 22, 2025

@0xIchigo is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
anchor-docs Ready Ready Preview Comment Sep 24, 2025 5:20am

@0xIchigo 0xIchigo requested a review from jacobcreech August 25, 2025 17:06
Copy link
Copy Markdown
Collaborator

@jamie-osec jamie-osec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Potentially CI should be updated to be pinned to the MSRV (though the rust-toolchain.toml should take care of this)

@jacobcreech
Copy link
Copy Markdown
Collaborator

@0xIchigo can you add the changelog update and we'll get this merged in

@jacobcreech jacobcreech merged commit 152d431 into solana-foundation:master Sep 24, 2025
54 checks passed
Otter-0x4ka5h pushed a commit to Otter-0x4ka5h/anchor that referenced this pull request Sep 28, 2025
* Add MSRV

* Make Clippy Happy

* Do Not Pin Rust Version in Program Crate

* Bump MSRV

* Bump to 1.89.0

* Update CHANGELOG.md with MSRV PR
WilfredAlmeida pushed a commit to KartikSoneji/anchor that referenced this pull request Oct 22, 2025
* Add MSRV

* Make Clippy Happy

* Do Not Pin Rust Version in Program Crate

* Bump MSRV

* Bump to 1.89.0

* Update CHANGELOG.md with MSRV PR
Otter-0x4ka5h pushed a commit to Otter-0x4ka5h/anchor that referenced this pull request Mar 25, 2026
* Add MSRV

* Make Clippy Happy

* Do Not Pin Rust Version in Program Crate

* Bump MSRV

* Bump to 1.89.0

* Update CHANGELOG.md with MSRV PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MSRV should be part of template

3 participants