fix: correct line number reporting for missing CHECK errors on duplic…

[ayushmishra2005]

• Fix safety_checks() method to iterate through structs explicitly instead of using generic unsafe_struct_fields()
• Add struct name to error messages for better context when duplicate field names exist
• Remove unused unsafe_struct_fields() method
• Update test expectations to match new error message format

Fixes #3915

[vercel]

@ayushmishra2005 is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

[0x4ka5h]

@ayushmishra2005, thanks for the contribution. When I run the tests by creating duplicate accounts, the compiler shows the below error instead of pointing to correct line.

--> programs/duplicate-names/src/lib.rs:5:1
  |
5 | #[program]
  | ^^^^^^^^^^
  |
  = help: message: Safety checks failed: 
                  /Users/0x4ka5h/Documents/intern/osec/development/anchor/tests/safety-checks/programs/duplicate-names/src/lib.rs:5:0
                  Struct field "my_account" in struct "FuncTwo" is unsafe, but is not documented.
                  Please add a `/// CHECK:` doc comment explaining why no checks through types are necessary.
                  Alternatively, for reasons like quick prototyping, you may disable the safety checks
                  by using the `skip-lint` option.
                  See https://www.anchor-lang.com/docs/the-accounts-struct#safety-checks for more information.

Could you please make sure the changes works as expected and please try to add a test to verify the changes are working and setup CI workflow too.

[ayushmishra2005]

@ayushmishra2005, thanks for the contribution. When I run the tests by creating duplicate accounts, the compiler shows the below error instead of pointing to correct line.

--> programs/duplicate-names/src/lib.rs:5:1
  |
5 | #[program]
  | ^^^^^^^^^^
  |
  = help: message: Safety checks failed: 
                  /Users/0x4ka5h/Documents/intern/osec/development/anchor/tests/safety-checks/programs/duplicate-names/src/lib.rs:5:0
                  Struct field "my_account" in struct "FuncTwo" is unsafe, but is not documented.
                  Please add a `/// CHECK:` doc comment explaining why no checks through types are necessary.
                  Alternatively, for reasons like quick prototyping, you may disable the safety checks
                  by using the `skip-lint` option.
                  See https://www.anchor-lang.com/docs/the-accounts-struct#safety-checks for more information.

Could you please make sure the changes works as expected and please try to add a test to verify the changes are working and setup CI workflow too.

I have addressed this.

[0x4ka5h]

Thanks for the update here!
CI workflow tests are added but the error didnt showing up with correct line whereas the pr itself is for fix: correct line number ....
Take the following info as inputs and please made changes.

Including file path, line, column and struct name is helpful in error, since its still pointing out to #[program]
Constrain test.sh with line number

[0x4ka5h]

please take a look at the above comment

[nutafrost]

The fix: correct line number reporting for missing CHECK is mentioned in #4032