idl: Support NonZero<num> in IDL#3984
Open
jamie-osec wants to merge 1 commit intosolana-foundation:masterfrom
Open
idl: Support NonZero<num> in IDL#3984jamie-osec wants to merge 1 commit intosolana-foundation:masterfrom
NonZero<num> in IDL#3984jamie-osec wants to merge 1 commit intosolana-foundation:masterfrom
Conversation
|
@jamie-osec is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
jamie-osec
force-pushed
the
idl-nonzero
branch
from
8875c1d to
3349f01
Compare
Otter-0x4ka5h
suggested changes
Nov 12, 2025
Contributor
There was a problem hiding this comment.
hey @jamie-osec, could you please run and fix the errors from code? also fix CI workflow tests
clubby789
force-pushed
the
idl-nonzero
branch
from
3349f01 to
9a5f646
Compare
jamie-osec
force-pushed
the
idl-nonzero
branch
from
9a5f646 to
8c4a1a5
Compare
Collaborator
Author
|
I think I accidentally added partial changes from another PR 🤔 should be okay now |
jamie-osec
force-pushed
the
idl-nonzero
branch
from
8c4a1a5 to
ff4cb69
Compare
Otter-0x4ka5h
suggested changes
Nov 12, 2025
Contributor
Otter-0x4ka5h
left a comment
Otter-0x4ka5h
left a comment
There was a problem hiding this comment.
no function or associated item named
insert_typesfound for structstd::num::NonZeroin the current scope
the error is still raising! Did you tested on your side?
Collaborator
Author
|
How are you getting that error? I can build programs taking |
clubby789
force-pushed
the
idl-nonzero
branch
2 times, most recently
from
dcd66b8 to
ea73acc
Compare
jamie-osec
force-pushed
the
idl-nonzero
branch
from
ea73acc to
2836bbc
Compare
Collaborator
Author
|
Updated to support |
Otter-0x4ka5h
approved these changes
Nov 13, 2025
0x4ka5h
approved these changes
Nov 13, 2025
Collaborator
Author
|
Needs implementing on the TS side |
jamie-osec
force-pushed
the
idl-nonzero
branch
2 times, most recently
from
ab70f3e to
84f6694
Compare
jamie-osec
force-pushed
the
idl-nonzero
branch
from
84f6694 to
ee71a8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3940