lang: Handle invalid camel case ident more gracefully#4021
Merged
jacobcreech merged 1 commit intosolana-foundation:masterfrom Nov 28, 2025
Merged
lang: Handle invalid camel case ident more gracefully#4021jacobcreech merged 1 commit intosolana-foundation:masterfrom
jacobcreech merged 1 commit intosolana-foundation:masterfrom
Conversation
|
@jamie-osec is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
0x4ka5h
requested changes
Oct 24, 2025
Collaborator
0x4ka5h
left a comment
0x4ka5h
left a comment
There was a problem hiding this comment.
can we also use the error propagation here? which is currently just unwrap()
https://github.com/jamie-osec/anchor/blob/bf495ac3df5483a80c37b51ad534ee8fb47821bc/lang/syn/src/codegen/program/common.rs#L45
jamie-osec
force-pushed
the
invalid-ident
branch
from
762566f to
04b079c
Compare
Otter-0x4ka5h
suggested changes
Oct 31, 2025
Contributor
Otter-0x4ka5h
left a comment
Otter-0x4ka5h
left a comment
There was a problem hiding this comment.
Do you know what causes these error and results in failing tests?
jamie-osec
force-pushed
the
invalid-ident
branch
from
04b079c to
be9ced5
Compare
jacobcreech
approved these changes
Nov 28, 2025
github-project-automation
bot
moved this from Security Review Done
to Done
in Anchor 1.0
Otter-0x4ka5h
pushed a commit
to Otter-0x4ka5h/anchor
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4017
Ident::newpanics on invalid identifiers;syn::parse_stris the recommended alternative for untrusted input.