fix(idl): Respect offset = ... in IDL generation for custom errors#4040
Merged
jacobcreech merged 1 commit intosolana-foundation:masterfrom Nov 28, 2025
Merged
Conversation
|
@jamie-osec is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
jamie-osec
force-pushed
the
idl-respect-error-offset
branch
2 times, most recently
from
3ef3599 to
19c5b6c
Compare
jamie-osec
force-pushed
the
idl-respect-error-offset
branch
from
19c5b6c to
8bfbbfd
Compare
jamie-osec
added
breaking
Minor
swaroop-osec
approved these changes
Nov 6, 2025
jacobcreech
approved these changes
Nov 28, 2025
github-project-automation
bot
moved this from Security Review Done
to Done
in Anchor 1.0
Otter-0x4ka5h
pushed a commit
to Otter-0x4ka5h/anchor
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4039
This issue led to a mismatch between generated IDLs and generated code if a custom
offsetwas used with the error code.Regex-based GH search indicates the impact of this was likely low.