fix: Add edition and rust-version to workspace.package template#4048
fix: Add edition and rust-version to workspace.package template#4048AvhiMaz wants to merge 3 commits intosolana-foundation:masterfrom
Conversation
|
@AvhiMaz is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
hi @jamie-osec can you please review this? thank you |
|
LGTM, though we'll need to ensure users have an up-to-date platform-tools somehow |
pub fn get_solana_version() -> Option<String> {
let output = std::process::Command::new("solana")
.arg("--version")
.output()
.ok()?;
if output.status.success() {
let version_str = String::from_utf8(output.stdout).ok()?;
version_str
.split_whitespace()
.last()
.map(|v| v.trim().to_string())
} else {
None
}
}can we create a func like this and call it which automatically injects the detected version into |
|
We can evaluate this in another PR, this change LGTM for now 🙂 |
got it ser, If you create this issue, please assign it to me, I’d like to work on it. |
|
Needs #4098 |
Ensures proper dependency resolution by specifying edition and rust-version in [workspace.package] instead of at program level, allowing dependency resolution to respect these constraints and prevent incompatible crate versions from being selected. Fixes solana-foundation#4047 Signed-off-by: AvhiMaz <avhimazumder5@outlook.com>
39f28c1 to
2b438fa
Compare
Signed-off-by: AvhiMaz <avhimazumder5@outlook.com>
|
@jamie-osec a test was failing. fixed it, lmk what you think about the fix made |
Signed-off-by: AvhiMaz <avhimazumder5@outlook.com>
Summary
Ensures proper dependency resolution by specifying edition and rust-version
in [workspace.package] instead of at program level, allowing dependency
resolution to respect these constraints and prevent incompatible crate
versions from being selected.
Changes
File: cli/src/rust_template.rs
Fixes #4047