fix(idl): prevent panic in array type parsing#4167
Closed
TiagoCostaVieira wants to merge 1 commit intosolana-foundation:masterfrom
Closed
fix(idl): prevent panic in array type parsing#4167TiagoCostaVieira wants to merge 1 commit intosolana-foundation:masterfrom
TiagoCostaVieira wants to merge 1 commit intosolana-foundation:masterfrom
Conversation
- Replace unwrap() with proper error handling in IdlType::from_str
- Support both ';' and space as array delimiters for compatibility
- Add clear error messages for invalid array formats
- Resolves parsing of '[u8 32]' without causing panic
Fixes: Array type parsing bug where rsplit_once(';').unwrap() would panic
Signed-off-by: Tiago Vieira <tiagocosvieira@gmail.com>
|
@TiagoCostaVieira is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Closing in favour of #4029 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: Array type parsing bug where rsplit_once(';').unwrap() would panic