chore(client): Re-export relevant Solana crates from anchor-client#4213
chore(client): Re-export relevant Solana crates from anchor-client#4213jamie-osec wants to merge 1 commit intosolana-foundation:masterfrom
Conversation
|
@jamie-osec is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
jamie-osec
changed the title
jamie-osec
force-pushed
the
client-fixes
branch
from
2bf13e3 to
bfd8f08
Compare
| pub use solana_commitment_config; | ||
| pub use solana_keypair; | ||
| pub use solana_pubkey; | ||
| pub use solana_signer; | ||
| pub use solana_system_interface; |
There was a problem hiding this comment.
I had already made a PR (#4211) that exports the types used by our public API. Whether we should export crates that the client doesn't actually use (but people might find convenient) is another question, and the answer is not immediately clear to me when we consider our new approach of minimizing bulk exports.
There was a problem hiding this comment.
I'm inclined to say it makes sense to do this, at least for the bare minimum types which are necessary to create a client (especially when these crates are already in anchor-clients dep graph, unlike in the case of re-exporting the entire solana-sdk)
github-project-automation
bot
moved this from Security Review Required
to Done
in Anchor 1.0
jamie-osec
force-pushed
the
client-fixes
branch
from
bfd8f08 to
b48ed28
Compare
github-project-automation
bot
moved this from Security Review Done
to Done
in Anchor 1.0
4 participants
anchor_client(and update examples to match)