Skip to content

feat(examples): add TypeScript types to next-js example#44

Merged
stevesarmiento merged 2 commits intosolana-foundation:mainfrom
evan976:feature/add-typescript-types-to-examples
Feb 13, 2026
Merged

feat(examples): add TypeScript types to next-js example#44
stevesarmiento merged 2 commits intosolana-foundation:mainfrom
evan976:feature/add-typescript-types-to-examples

Conversation

@evan976
Copy link
Copy Markdown
Contributor

@evan976 evan976 commented Feb 10, 2026

This PR brings TypeScript to the Next.js example:

  • Files converted to .ts/.tsx
  • Typed components props

Example still works normally (pnpm dev in examples/next-js).
All checks pass (type-check, lint, build).

No core package changes.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 10, 2026

@evan976 is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Feb 10, 2026

Greptile Overview

Greptile Summary

This PR updates the Next.js example’s featured-section.tsx to use TypeScript by adding inline prop typings to several example components (e.g., WalletModal, WalletDropdownContent, and Base UI variants). These changes are confined to the example UI layer and don’t touch the core connector packages.

One behavioral change is included: the Base UI menu popup className drops the outline utility while keeping outline-1 outline-gray-200, which likely removes the intended outline styling.

Confidence Score: 4/5

  • This PR is safe to merge once the Base UI popup outline class regression is fixed.
  • Changes are limited to example TypeScript prop typing, with one concrete UI regression: removing the outline utility prevents outline-1/outline-gray-200 from taking effect, changing the rendered styling.
  • examples/next-js/components/playground/featured-section.tsx

Important Files Changed

Filename Overview
examples/next-js/components/playground/featured-section.tsx Adds inline TypeScript prop types to several exported components; one className change removes the outline utility, which likely breaks the intended outline styling on Base UI menu popup.

Sequence Diagram

sequenceDiagram
    participant User
    participant ConnectButtonBaseUI
    participant Menu as BaseUI Menu
    participant WalletDropdownContentBaseUI

    User->>ConnectButtonBaseUI: Click trigger button
    ConnectButtonBaseUI->>Menu: Open popup
    Menu->>WalletDropdownContentBaseUI: Render dropdown content
    Note over Menu: Popup className lost `outline` utility
    Note over Menu: outline-1/outline-gray-200 won't apply
    User-->>Menu: Sees missing outline styling
Loading

Copy link
Copy Markdown

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
connectorkit-playground Ready Ready Preview, Comment Feb 13, 2026 7:43am

Request Review

@stevesarmiento stevesarmiento merged commit 2bc98b3 into solana-foundation:main Feb 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants