Upgrade to Kit v6#45
Conversation
|
@mcintyre94 is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Greptile OverviewGreptile SummaryThis PR upgrades The main functional impact is dependency resolution: the lockfile now brings in Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer/CI
participant PNPM as pnpm
participant Lock as pnpm-lock.yaml
participant Reg as npm registry
participant Kit as @solana/kit@6
Dev->>PNPM: pnpm install
PNPM->>Lock: Read resolved versions
Lock-->>PNPM: @solana/kit ^6 resolves to 6.0.1
PNPM->>Reg: Fetch @solana/*@6.x tarballs
Reg-->>PNPM: Packages include engines node>=20.18.0
PNPM-->>Dev: Install succeeds or fails
Note over PNPM,Dev: Under Node < 20.18, engine checks may block install/runtime
|
| peerDependencies: | ||
| typescript: '>=5.3.3' | ||
|
|
There was a problem hiding this comment.
Node engine mismatch
This lockfile now pulls in @solana/*@6.0.1 packages that declare engines: {node: '>=20.18.0'} (e.g. @solana/accounts@6.0.1). The repo root still declares "engines": {"node": ">=18.0.0"} in package.json, so installs/runs under Node 18 will fail (or be blocked depending on pnpm settings). Either bump the repo engine requirement to match Node 20.18+ or pin @solana/kit/related deps to versions compatible with Node 18.
There was a problem hiding this comment.
I've updated the Node engine to >= 20.18.0
Note that this is not a change in Kit v6, we've been using >= 20.18.0 since v2: anza-xyz/kit@1adf435
So this is an existing issue with the Node 18 support in this repo
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
add explicit issues write permission and skip comment posting for fork prs to avoid 403 integration errors
Kit v6 is a breaking change, but mostly the changes are to do with instruction plans so nothing that affects connectorkit!