Skip to content

[ci] changeset based package publishing#150

Merged
nickfrosty merged 10 commits intomainfrom
ci-publishing
Jun 13, 2025
Merged

[ci] changeset based package publishing#150
nickfrosty merged 10 commits intomainfrom
ci-publishing

Conversation

@nickfrosty
Copy link
Copy Markdown
Contributor

adding changeset based package publishing

Fixes: #148

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 11, 2025

⚠️ No Changeset found

Latest commit: 58c150c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nickfrosty nickfrosty self-assigned this Jun 11, 2025
@nickfrosty
Copy link
Copy Markdown
Contributor Author

@beeman this is ready for a first pass look. It should be good to go. If this is satisfactory, I will update the MAINTEINERS.md to reflect this. I would also recommend we remove the ci.yml script in favor of the PR one I added. Accomplishes the same task, but it uses a matrix of versions to test/lint on. Plus is inline with gill, kit, and wallet ui

@nickfrosty nickfrosty requested a review from beeman June 11, 2025 17:00
@nickfrosty
Copy link
Copy Markdown
Contributor Author

also worth considering: only running the test templates action when the the src dir or specific config files changes (like package json). This should prevent the excess runners when they are not needed

Copy link
Copy Markdown
Collaborator

@beeman beeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @nickfrosty, thanks! 🙏

@beeman
Copy link
Copy Markdown
Collaborator

beeman commented Jun 11, 2025

@beeman this is ready for a first pass look. It should be good to go. If this is satisfactory, I will update the MAINTEINERS.md to reflect this. I would also recommend we remove the ci.yml script in favor of the PR one I added. Accomplishes the same task, but it uses a matrix of versions to test/lint on. Plus is inline with gill, kit, and wallet ui

Looks all good to me so far!

Happy for you to update the MAINTAINERS file and remove the obsolete ci.yml.

Also created a follow-up issue #154 for optimizing the e2e-test so it'll test unrelated stuff faster.

@nickfrosty nickfrosty merged commit c431a8d into main Jun 13, 2025
70 checks passed
@nickfrosty nickfrosty deleted the ci-publishing branch June 13, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ci] utilize ci/cd based publishing

2 participants