Skip to content

fix: show all mobile templates#249

Merged
beeman merged 1 commit into
mainfrom
beeman/include-kotlin-compose-mobile
May 23, 2026
Merged

fix: show all mobile templates#249
beeman merged 1 commit into
mainfrom
beeman/include-kotlin-compose-mobile

Conversation

@beeman

@beeman beeman commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Remove the Expo-only keyword filter from the Solana Mobile menu so native mobile templates such as kotlin-compose are selectable.

Add a patch changeset for the CLI prompt behavior.

In preparation for solana-foundation/templates#409

@changeset-bot

changeset-bot Bot commented May 22, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5759726

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-solana-dapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented May 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/solana-foundation/create-solana-dapp@249

commit: 5759726

@greptile-apps

greptile-apps Bot commented May 22, 2026

Copy link
Copy Markdown

Greptile Summary

This PR removes the keywords: ['expo'] filter from the Solana Mobile menu entry in get-menu-config.ts, allowing all templates in the mobile group to appear in the CLI prompt rather than only Expo-based ones.

  • src/utils/get-menu-config.ts: keywords for the solana-mobile menu item is set to [], which the menu-utils.ts logic treats as "include all templates from the group." The description is also updated from "Solana Mobile Templates based on Expo" to "Solana Mobile Templates" to reflect the broader scope.
  • .changeset/mobile-template-filter.md: Adds a patch changeset entry documenting the behavior change for consumers of the CLI.

Confidence Score: 5/5

Safe to merge — the change is minimal, well-understood, and backed by the existing keyword-filter logic in menu-utils.ts.

The only changed behaviour is that the Solana Mobile CLI menu now surfaces every template in the mobile group instead of filtering to Expo-only. The menu-utils.ts logic already handles keywords: [] as show all, so no new code paths are introduced and the change is entirely additive.

No files require special attention.

Important Files Changed

Filename Overview
src/utils/get-menu-config.ts Removes the keywords: ['expo'] filter from the Solana Mobile menu entry and updates its description; now all templates in the 'mobile' group are shown instead of only Expo-tagged ones.
.changeset/mobile-template-filter.md Adds a patch changeset entry documenting the broadened mobile template filter for the CLI prompt.

Reviews (2): Last reviewed commit: "fix: show all mobile templates" | Re-trigger Greptile

Remove the Expo-only keyword filter from the Solana Mobile menu so native mobile templates such as kotlin-compose are selectable.

Add a patch changeset for the CLI prompt behavior.
@beeman beeman force-pushed the beeman/include-kotlin-compose-mobile branch from 7c33a6f to 5759726 Compare May 22, 2026 23:18
@beeman beeman requested a review from amilz May 22, 2026 23:19
@beeman beeman merged commit 41835c6 into main May 23, 2026
7 checks passed
@beeman beeman deleted the beeman/include-kotlin-compose-mobile branch May 23, 2026 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants