Skip to content

chore: improve semicolon rule#462

Merged
ngundotra merged 5 commits intosolana-foundation:masterfrom
rogaldh:feat/improve-semicolon-rule
Feb 14, 2025
Merged

chore: improve semicolon rule#462
ngundotra merged 5 commits intosolana-foundation:masterfrom
rogaldh:feat/improve-semicolon-rule

Conversation

@rogaldh
Copy link
Copy Markdown
Contributor

@rogaldh rogaldh commented Feb 13, 2025

  • Add semicolon rule for eslint
    • Current configuration allows to be inconsistent with semicolon
  • Add script to check for format errors (it uses current configuration for prettier)

Next thing that might be good to implement: check for prettier' errors at lint step. This allows to prevent passing CI checks for codebase formatted incorrectly.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 13, 2025

@rogaldh is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@ngundotra
Copy link
Copy Markdown
Contributor

need to rebase

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 6:08pm

@ngundotra ngundotra merged commit 6f8cb4e into solana-foundation:master Feb 14, 2025
2 checks passed
@rogaldh rogaldh deleted the feat/improve-semicolon-rule branch February 18, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants