Skip to content

Sort activated feature gates #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ngundotra merged 1 commit into from
Feb 27, 2025
Merged

Sort activated feature gates #473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 37 additions & 15 deletions app/utils/feature-gate/featureGate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,43 @@ export function UpcomingFeatures() {
return null;
}

const filteredFeatures = (FEATURES as FeatureInfoType[]).filter((feature: FeatureInfoType) => {
switch (cluster) {
case Cluster.MainnetBeta:
// Show features activated on devnet and testnet
return feature.devnetActivationEpoch !== null && feature.testnetActivationEpoch !== null;
case Cluster.Devnet:
// Show features activated on testnet, mark if already activated on devnet
return feature.testnetActivationEpoch !== null;
case Cluster.Testnet:
// Only show features not yet activated on testnet
return feature.testnetActivationEpoch === null;
default:
return false;
}
});
const filteredFeatures = (FEATURES as FeatureInfoType[])
.filter((feature: FeatureInfoType) => {
switch (cluster) {
case Cluster.MainnetBeta:
// Show features activated on devnet and testnet
return feature.devnetActivationEpoch !== null && feature.testnetActivationEpoch !== null;
case Cluster.Devnet:
// Show features activated on testnet, mark if already activated on devnet
return feature.testnetActivationEpoch !== null;
case Cluster.Testnet:
// Only show features not yet activated on testnet
return feature.testnetActivationEpoch === null;
default:
return false;
}
})
.sort((a, b) => {
// Helper function to check if a feature is activated on current cluster
const isActivated = (feature: FeatureInfoType) => {
switch (cluster) {
case Cluster.MainnetBeta:
return feature.mainnetActivationEpoch !== null;
case Cluster.Devnet:
return feature.devnetActivationEpoch !== null;
case Cluster.Testnet:
return feature.testnetActivationEpoch !== null;
default:
return false;
}
};

// Sort activated features to end while preserving existing ordering
const aActivated = isActivated(a);
const bActivated = isActivated(b);
if (aActivated === bActivated) return 0;
return aActivated ? 1 : -1;
});

if (filteredFeatures.length === 0) {
return null;
Expand Down