Improve feature gate description for 0182#474
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 886dd89 in 40 seconds
More details
- Looked at
22lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. app/utils/feature-gate/featureGates.json:240
- Draft comment:
Good description update. Ensures clarity on compute unit charging. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
2. app/utils/feature-gate/featureGates.json:284
- Draft comment:
Title cleanup: removing redundant prefix improves clarity. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
3. app/utils/feature-gate/featureGates.json:240
- Draft comment:
Updated description clarifies computation charge; looks good. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
4. app/utils/feature-gate/featureGates.json:284
- Draft comment:
Removing 'Feature Gate:' prefix improves title consistency. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
Workflow ID: wflow_nkK4l2kC14y5Nx0T
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Update descriptions and titles for feature gates
0182and0191infeatureGates.json.0182to "Charge allocated compute units for sBPF failures instead of consumed compute units" infeatureGates.json.0191to "Charge fees for transactions that fail to load" infeatureGates.json.This description was created by
for 886dd89. It will automatically update as commits are pushed.