Skip to content

Improve feature gate description for 0182#474

Merged
ngundotra merged 1 commit intomasterfrom
feature-gates-desc-update
Feb 27, 2025
Merged

Improve feature gate description for 0182#474
ngundotra merged 1 commit intomasterfrom
feature-gates-desc-update

Conversation

@ngundotra
Copy link
Copy Markdown
Contributor

@ngundotra ngundotra commented Feb 27, 2025

Important

Update descriptions and titles for feature gates 0182 and 0191 in featureGates.json.

  • Feature Gate Descriptions:
    • Update description for feature gate 0182 to "Charge allocated compute units for sBPF failures instead of consumed compute units" in featureGates.json.
  • Feature Gate Titles:
    • Update title for feature gate 0191 to "Charge fees for transactions that fail to load" in featureGates.json.

This description was created by Ellipsis for 886dd89. It will automatically update as commits are pushed.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 7:04pm

Copy link
Copy Markdown
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 886dd89 in 40 seconds

More details
  • Looked at 22 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. app/utils/feature-gate/featureGates.json:240
  • Draft comment:
    Good description update. Ensures clarity on compute unit charging.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
2. app/utils/feature-gate/featureGates.json:284
  • Draft comment:
    Title cleanup: removing redundant prefix improves clarity.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
3. app/utils/feature-gate/featureGates.json:240
  • Draft comment:
    Updated description clarifies computation charge; looks good.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
4. app/utils/feature-gate/featureGates.json:284
  • Draft comment:
    Removing 'Feature Gate:' prefix improves title consistency.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None

Workflow ID: wflow_nkK4l2kC14y5Nx0T


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@ngundotra ngundotra merged commit 602219b into master Feb 27, 2025
3 checks passed
@ngundotra ngundotra deleted the feature-gates-desc-update branch February 27, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant