Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to ac9e4eb in 1 minute and 57 seconds
More details
- Looked at
179lines of code in2files - Skipped
0files when reviewing. - Skipped posting
7drafted comments based on config settings.
1. CONTRIBUTING.md:163
- Draft comment:
The removal of the PR description template and detailed Code Style instructions might leave new contributors less guided. Ensure that alternative or consolidated guidelines are documented elsewhere. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. README.md:9
- Draft comment:
The updated 'Contributing' section is concise; ensure that detailed dev instructions (e.g. environment setup and dependency guidelines) remain easily accessible, possibly by cross-linking the CONTRIBUTING.md. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment is asking the PR author to ensure that documentation is accessible, which is not allowed by the rules. It does not provide a specific code suggestion or point out a specific issue with the code.
3. CONTRIBUTING.md:23
- Draft comment:
The added 'Important Note' clearly advises contributors regarding wallet adapter functionality. Consider including a link to a policy or additional details if these guidelines are maintained elsewhere. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
4. CONTRIBUTING.md:55
- Draft comment:
The troubleshooting step using 'blow reset to master' is a bit informal. Consider rephrasing it (e.g., 'perform a hard reset to the master branch') to keep the documentation professional. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
5. CONTRIBUTING.md:163
- Draft comment:
The removal of the PR Description Template and Code Style sections reduces redundancy, but these guidelines help maintain consistency. If they are still relevant, consider linking to their updated location or providing a brief reference. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
6. README.md:9
- Draft comment:
The 'Contributing' section in the README now succinctly directs users to the CONTRIBUTING.md guide, promoting DRY principles. This consolidation improves readability. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
7. README.md:35
- Draft comment:
There appears to be a subject–verb agreement issue on line 35. The sentence reads: "Any content produced by SF or developer resources that SF provides, are for educational and inspiration purposes only." Consider revising it to "...is for educational and inspirational purposes only." to improve clarity and grammatical correctness. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_i3Vto7COO31gkWHp
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update contributions.md & readme.md
Important
Update
CONTRIBUTING.mdandREADME.mdto improve contribution guidelines and development setup instructions.pnpmversion requirement and troubleshooting steps.CONTRIBUTING.mdfor detailed guidelines.This description was created by
for ac9e4eb. It will automatically update as commits are pushed.