Skip to content

fs-sm the feature-gates#528

Merged
ngundotra merged 1 commit intomasterfrom
fixes/feature-gate-table-bad-text
Apr 8, 2025
Merged

fs-sm the feature-gates#528
ngundotra merged 1 commit intomasterfrom
fixes/feature-gate-table-bad-text

Conversation

@ngundotra
Copy link
Copy Markdown
Contributor

@ngundotra ngundotra commented Apr 8, 2025

Description

Fixes the address on the address text size for feature gates on the home page

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2025 10:51pm

Copy link
Copy Markdown
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e6863c4 in 22 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. app/utils/feature-gate/featureGate.tsx:125
  • Draft comment:
    Added 'fs-sm' class to the element for Address consistency. Verify this style change aligns with design guidelines.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
2. app/utils/feature-gate/featureGate.tsx:125
  • Draft comment:
    Adding className='fs-sm' to the ensures consistent text sizing for the Address component. Ensure that this styling is intended and harmonizes with the existing styles applied inside the Address component.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    The comment is asking the PR author to ensure that the styling is intended and harmonizes with existing styles, which violates the rule against asking the author to confirm their intention or ensure behavior. It does not provide a specific suggestion or ask for a specific test to be written. Therefore, this comment should not be approved.

Workflow ID: wflow_LypELoebzCCa7ofB


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@ngundotra ngundotra merged commit 022e1ba into master Apr 8, 2025
1 of 4 checks passed
@ngundotra ngundotra deleted the fixes/feature-gate-table-bad-text branch April 8, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant