feat/improve T22 account page

[rogaldh]

Description

This PR displays Token Extensions for other accounts.

Type of change

• New feature

Screenshots

Testing

pnpm dev > Visit links below

Token Account: http://localhost:3000/address/7owTEfBdJ2nEdxaUZ2Hm6XevkG7FqHgmeVhkZbUTCCQT/token-extensions
Multisig Account: http://localhost:3000/address/FtrZqgM9begkaLHq3f4hGEUrAK1jjJpkc8hZ1hVk3EDN/token-extensions

Related Issues

Relates to: #516

Checklist

• My code follows the project's style guidelines
• I have added tests that prove my fix/feature works
• All tests pass locally and in CI
• CI/CD checks pass
• I have included screenshots for protocol screens (if applicable)

---

Important

Add feature to display token extensions for accounts, handling different account types and rendering logic in page-client.tsx and TokenExtensionsCard.tsx.

• Behavior:
  • Displays Token Extensions for accounts in page-client.tsx using TokenExtensionsCard.
  • Handles mint and account types, rendering TokenExtensionsCard if extensions exist, otherwise shows NoResults.
  • Uses ErrorBoundary to handle errors in TokenExtensionsEntriesPageClient.
• Components:
  • TokenExtensionsCard in TokenExtensionsCard.tsx now fetches token info and displays extensions using TokenExtensionsSection.
  • Introduces populateTokenExtensions() to parse and sort extensions.
• Misc:
  • Removes unused epoch variable in TokenAccountSection.tsx.
  • Updates TokenExtensionsPage in page.tsx to use TokenExtensionsEntriesPageClient.

^{This description was created by for f41dd7e. It will automatically update as commits are pushed.}

[vercel]

@rogaldh is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to f41dd7e in 2 minutes and 58 seconds

More details

• Looked at 179 lines of code in 4 files
• Skipped 0 files when reviewing.
• Skipped posting 10 drafted comments based on config settings.

1. app/components/account/TokenExtensionsCard.tsx:36

• Draft comment:
  Typo: "satisty" should be "satisfy".
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
  While the typo correction is technically accurate, it's in a comment rather than in code. Comments are documentation and typos in them don't affect functionality. The rules state we should only keep comments that require clear code changes and not make purely informative comments. A typo in a comment is very minor.
  The typo could make the code slightly less professional looking and might momentarily confuse readers. Documentation quality does matter.
  While documentation quality matters, this is an extremely minor issue that doesn't impact code understanding or functionality. The meaning is still clear despite the typo.
  Delete this comment as it's too minor and doesn't require a functional code change.

2. app/components/account/TokenExtensionsCard.tsx:56

• Draft comment:
  Consider memoizing the result of populateTokenExtensions if the mintExtensions prop rarely changes.
• Reason this comment was not posted:
  Confidence changes required: 50% <= threshold 50%
  None

3. app/components/account/TokenAccountSection.tsx:512

• Draft comment:
  Ensure the removal of TokenExtensionRow mapping is intentional, as this change affects how token extensions are displayed in the account section.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

4. app/components/account/TokenExtensionsCard.tsx:59

• Draft comment:
  Using a Map to accumulate extensions keyed by the extension type deduplicates entries. Confirm that losing multiple entries of the same type is intended.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

5. app/components/account/TokenExtensionsCard.tsx:95

• Draft comment:
  Unreachable 'break' statements after return in populatePartialParsedTokenExtension can be removed to clean up the code.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

6. app/components/account/TokenExtensionsCard.tsx:37

• Draft comment:
  Throwing an error during render (when tokenInfo is missing or decimals is null) relies on an external ErrorBoundary. Consider returning a fallback UI or adding more context for better debugging.
• Reason this comment was not posted:
  Confidence changes required: 50% <= threshold 50%
  None

7. app/address/[address]/token-extensions/page-client.tsx:18

• Draft comment:
  Consider changing 'Can not fetch extensions.' to 'Cannot fetch extensions.' for a more standard contraction.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
  The comment is about UI text content. According to the rules, we should "NOT comment on any pure frontend UI or styling changes, only logic. Assume that if the author changed the UI, they did it correctly." While "Cannot" is technically more standard, this is purely a UI text change with no impact on functionality.
  The change could improve text consistency across the codebase. Maybe there are style guidelines that require "cannot" over "can not".
  Even if there are style guidelines, UI text changes should be handled through a different process, not PR comments. The rules explicitly say to ignore UI changes.
  Delete this comment as it relates purely to UI text content, which we are instructed to ignore.

8. app/components/account/TokenAccountSection.tsx:281

• Draft comment:
  In the Bridged Asset Contract row, the tag's href is using 'tokenInfo.extensions.bridgeContract' instead of 'tokenInfo.extensions.assetContract'. Please update it to use the correct asset contract URL.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

9. app/components/account/TokenAccountSection.tsx:980

• Draft comment:
  In the mapping over 'extension.additionalMetadata', the key is provided as a string literal "{keyValuePair[0]}". It should be written as {keyValuePair[0]} without extra quotes so that the key is correctly evaluated.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

10. app/components/account/TokenExtensionsCard.tsx:36

• Draft comment:
  Typographical error: Replace 'satisty' with 'satisfy' in the comment on checking decimals.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
  While the comment is technically correct about the typo, fixing typos in comments is a very minor issue that doesn't affect functionality. The rules state not to make comments that are obvious or unimportant. A typo in a comment is quite unimportant.
  The typo could be seen as reducing code quality and professionalism. Poor spelling in comments could make the code less maintainable.
  While code quality is important, this is an extremely minor issue that doesn't warrant a PR comment. The rules explicitly state not to make obvious or unimportant comments.
  The comment should be deleted as it points out an unimportant typo that doesn't meaningfully impact code quality.

Workflow ID: wflow_U8BCmRpHFUboTTvT

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ngundotra]

Might need follow up PR to remove TokenExtensionRow.

Waiting on #529 to be merged

[ngundotra]

CI not passing because forks can't access secrets / vars