chore:(PRO-259) Add additional Validation Checks

crates/lib/src/signer/utils.rs

@@ -3,7 +3,7 @@ use std::env;
 use crate::KoraError;
 
 pub fn hex_to_bytes(hex: &str) -> Result<Vec<u8>, anyhow::Error> {
-    if hex.len() % 2 != 0 {
+    if !hex.len().is_multiple_of(2) {
         return Err(anyhow::anyhow!("Hex string must have even length"));
     }
 

crates/lib/src/validator/config_validator.rs

@@ -2,7 +2,7 @@ use std::str::FromStr;
 
 use crate::{
     admin::token_util::find_missing_atas,
-    config::Token2022Config,
+    config::{SplTokenConfig, Token2022Config},
     fee::price::PriceModel,
     oracle::PriceSource,
     state::get_config,
@@ -119,6 +119,15 @@ impl ConfigValidator {
             errors.push(format!("Invalid spl paid token address: {e}"));
         }
 
+        // Warn if using "All" for allowed_spl_paid_tokens
+        if matches!(config.validation.allowed_spl_paid_tokens, SplTokenConfig::All) {
+            warnings.push(
+                "⚠️  Using 'All' for allowed_spl_paid_tokens - this accepts ANY SPL token for payment. \
+                Consider using an explicit allowlist to reduce volatility risk and protect against \
+                potentially malicious or worthless tokens being used for fees.".to_string()
+            );
+        }
+
         // Validate disallowed accounts
         if let Err(e) = TokenUtil::check_valid_tokens(&config.validation.disallowed_accounts) {
             errors.push(format!("Invalid disallowed account address: {e}"));
@@ -680,11 +689,15 @@ mod tests {
 
         let _ = update_config(config);
 
-        let mock_account = create_mock_program_account();
         let rpc_client = RpcMockBuilder::new().build();
 
         let result = ConfigValidator::validate_with_result(&rpc_client, true).await;
         assert!(result.is_ok());
+
+        // Check that it warns about using "All" for allowed_spl_paid_tokens
+        let warnings = result.unwrap();
+        assert!(warnings.iter().any(|w| w.contains("Using 'All' for allowed_spl_paid_tokens")));
+        assert!(warnings.iter().any(|w| w.contains("volatility risk")));
     }
 
     #[tokio::test]