docs: (PRO-272) add fees summary#214
Merged
dev-jodee merged 1 commit intobugfix/pro-268-estimate-txn-fee-needs-to-include-transfer-feesfrom Sep 2, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 30c139a in 58 seconds. Click for details.
- Reviewed
58lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/operators/FEES.md:31
- Draft comment:
Add a newline at the end of the file to conform to best practices. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This is a new file being added, so it is about a change. However, the comment is about a very minor formatting issue. Our rules state not to make comments that are obvious or unimportant. Most editors automatically add trailing newlines, and this kind of formatting detail doesn't impact functionality. A missing trailing newline could cause issues with some tools or make diffs less clean. Some would argue this is a valid best practice to enforce. While true, this is still too minor of an issue to warrant a PR comment. Many tools handle this automatically, and it doesn't affect the document's content or functionality. Delete this comment as it violates our rule about not making obvious or unimportant comments. This kind of minor formatting issue doesn't warrant a PR comment.
2. docs/operators/README.md:61
- Draft comment:
The link to the Fee Estimation Guide in README is clear and useful. Good improvement. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_05OvAAF36PtZJDEu
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
dev-jodee
approved these changes
Sep 2, 2025
d11470d
into
bugfix/pro-268-estimate-txn-fee-needs-to-include-transfer-fees
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds summary table explaining fee estimation
merges into #212
Important
Adds
FEES.mddetailing Kora's fee estimation and updatesREADME.mdto reference it.FEES.mdtodocs/operators/, detailing Kora's fee estimation process and components.README.mdto include a reference to the newFEES.mdguide, highlighting its importance for node operators.This description was created by
for 30c139a. You can customize this summary. It will automatically update as commits are pushed.