Skip to content

docs: (PRO-272) add fees summary#214

Merged
dev-jodee merged 1 commit intobugfix/pro-268-estimate-txn-fee-needs-to-include-transfer-feesfrom
docs/add-fees-summary
Sep 2, 2025
Merged

docs: (PRO-272) add fees summary#214
dev-jodee merged 1 commit intobugfix/pro-268-estimate-txn-fee-needs-to-include-transfer-feesfrom
docs/add-fees-summary

Conversation

@amilz
Copy link
Copy Markdown
Contributor

@amilz amilz commented Sep 2, 2025

adds summary table explaining fee estimation
merges into #212


Important

Adds FEES.md detailing Kora's fee estimation and updates README.md to reference it.

  • Documentation:
    • Adds FEES.md to docs/operators/, detailing Kora's fee estimation process and components.
    • Updates README.md to include a reference to the new FEES.md guide, highlighting its importance for node operators.

This description was created by Ellipsis for 30c139a. You can customize this summary. It will automatically update as commits are pushed.

@amilz amilz requested a review from dev-jodee September 2, 2025 19:17
@amilz amilz self-assigned this Sep 2, 2025
@linear
Copy link
Copy Markdown

linear bot commented Sep 2, 2025

PRO-272 add fees docs

Copy link
Copy Markdown
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 30c139a in 58 seconds. Click for details.
  • Reviewed 58 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/operators/FEES.md:31
  • Draft comment:
    Add a newline at the end of the file to conform to best practices.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This is a new file being added, so it is about a change. However, the comment is about a very minor formatting issue. Our rules state not to make comments that are obvious or unimportant. Most editors automatically add trailing newlines, and this kind of formatting detail doesn't impact functionality. A missing trailing newline could cause issues with some tools or make diffs less clean. Some would argue this is a valid best practice to enforce. While true, this is still too minor of an issue to warrant a PR comment. Many tools handle this automatically, and it doesn't affect the document's content or functionality. Delete this comment as it violates our rule about not making obvious or unimportant comments. This kind of minor formatting issue doesn't warrant a PR comment.
2. docs/operators/README.md:61
  • Draft comment:
    The link to the Fee Estimation Guide in README is clear and useful. Good improvement.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_05OvAAF36PtZJDEu

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@dev-jodee dev-jodee merged commit d11470d into bugfix/pro-268-estimate-txn-fee-needs-to-include-transfer-fees Sep 2, 2025
@amilz amilz deleted the docs/add-fees-summary branch September 2, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants