Skip to content

chore: (PRO-275) Set FeePayerPolicy defaults to false #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dev-jodee merged 2 commits into from
Sep 4, 2025
Merged

chore: (PRO-275) Set FeePayerPolicy defaults to false #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4c508f
chore: Set FeePayerPolicy defaults to false
amilz Sep 3, 2025
6eacc05
Update coverage badge [skip ci]
invalid-email-address Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/badges/coverage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"schemaVersion": 1, "label": "coverage", "message": "85.8%", "color": "green"}
{"schemaVersion": 1, "label": "coverage", "message": "85.6%", "color": "green"}
16 changes: 1 addition & 15 deletions crates/lib/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ impl ValidationConfig {
}
}

#[derive(Debug, Clone, Serialize, Deserialize, ToSchema)]
#[derive(Debug, Clone, Serialize, Deserialize, ToSchema, Default)]
pub struct FeePayerPolicy {
pub allow_sol_transfers: bool,
pub allow_spl_transfers: bool,
Expand All @@ -145,20 +145,6 @@ pub struct FeePayerPolicy {
pub allow_approve: bool,
}

impl Default for FeePayerPolicy {
fn default() -> Self {
Self {
allow_sol_transfers: true,
allow_spl_transfers: true,
allow_token2022_transfers: true,
allow_assign: true,
allow_burn: true,
allow_close_account: true,
allow_approve: true,
}
}
}

#[derive(Debug, Clone, Serialize, Deserialize, ToSchema)]
pub struct Token2022Config {
pub blocked_mint_extensions: Vec<String>,
Expand Down
14 changes: 7 additions & 7 deletions crates/lib/src/rpc_server/method/get_config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,13 @@ mod tests {
assert_eq!(response.validation_config.price_source, crate::oracle::PriceSource::Mock);

// Assert FeePayerPolicy defaults
assert!(response.validation_config.fee_payer_policy.allow_sol_transfers);
assert!(response.validation_config.fee_payer_policy.allow_spl_transfers);
assert!(response.validation_config.fee_payer_policy.allow_token2022_transfers);
assert!(response.validation_config.fee_payer_policy.allow_assign);
assert!(response.validation_config.fee_payer_policy.allow_burn);
assert!(response.validation_config.fee_payer_policy.allow_close_account);
assert!(response.validation_config.fee_payer_policy.allow_approve);
assert!(!response.validation_config.fee_payer_policy.allow_sol_transfers);
assert!(!response.validation_config.fee_payer_policy.allow_spl_transfers);
assert!(!response.validation_config.fee_payer_policy.allow_token2022_transfers);
assert!(!response.validation_config.fee_payer_policy.allow_assign);
assert!(!response.validation_config.fee_payer_policy.allow_burn);
assert!(!response.validation_config.fee_payer_policy.allow_close_account);
assert!(!response.validation_config.fee_payer_policy.allow_approve);

// Assert PriceConfig default (check margin value)
match response.validation_config.price.model {
Expand Down
47 changes: 31 additions & 16 deletions crates/lib/src/validator/transaction_validator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,8 +566,11 @@ mod tests {
let fee_payer = Pubkey::new_unique();
let recipient = Pubkey::new_unique();

// Test with allow_sol_transfers = true (default)
setup_default_config();
// Test with allow_sol_transfers = true
setup_config_with_policy(FeePayerPolicy {
allow_sol_transfers: true,
..Default::default()
});

let validator = TransactionValidator::new(fee_payer).unwrap();

Expand Down Expand Up @@ -597,8 +600,8 @@ mod tests {
let fee_payer = Pubkey::new_unique();
let new_owner = Pubkey::new_unique();

// Test with allow_assign = true (default)
setup_default_config();
// Test with allow_assign = true
setup_config_with_policy(FeePayerPolicy { allow_assign: true, ..Default::default() });

let validator = TransactionValidator::new(fee_payer).unwrap();

Expand Down Expand Up @@ -626,8 +629,11 @@ mod tests {
let fee_payer_token_account = Pubkey::new_unique();
let recipient_token_account = Pubkey::new_unique();

// Test with allow_spl_transfers = true (default)
setup_spl_token_config();
// Test with allow_spl_transfers = true
setup_spl_config_with_policy(FeePayerPolicy {
allow_spl_transfers: true,
..Default::default()
});

let validator = TransactionValidator::new(fee_payer).unwrap();

Expand Down Expand Up @@ -693,8 +699,11 @@ mod tests {
let recipient_token_account = Pubkey::new_unique();
let mint = Pubkey::new_unique();

// Test with allow_token2022_transfers = true (default)
setup_token2022_config();
// Test with allow_token2022_transfers = true
setup_token2022_config_with_policy(FeePayerPolicy {
allow_token2022_transfers: true,
..Default::default()
});

let validator = TransactionValidator::new(fee_payer).unwrap();

Expand Down Expand Up @@ -888,8 +897,8 @@ mod tests {
let fee_payer_token_account = Pubkey::new_unique();
let mint = Pubkey::new_unique();

// Test with allow_burn = true (default)
setup_spl_token_config();
// Test with allow_burn = true
setup_spl_config_with_policy(FeePayerPolicy { allow_burn: true, ..Default::default() });

let validator = TransactionValidator::new(fee_payer).unwrap();

Expand Down Expand Up @@ -955,8 +964,11 @@ mod tests {
let fee_payer_token_account = Pubkey::new_unique();
let destination = Pubkey::new_unique();

// Test with allow_close_account = true (default)
setup_spl_token_config();
// Test with allow_close_account = true
setup_spl_config_with_policy(FeePayerPolicy {
allow_close_account: true,
..Default::default()
});

let validator = TransactionValidator::new(fee_payer).unwrap();

Expand Down Expand Up @@ -1005,8 +1017,8 @@ mod tests {
let fee_payer_token_account = Pubkey::new_unique();
let delegate = Pubkey::new_unique();

// Test with allow_approve = true (default)
setup_spl_token_config();
// Test with allow_approve = true
setup_spl_config_with_policy(FeePayerPolicy { allow_approve: true, ..Default::default() });

let validator = TransactionValidator::new(fee_payer).unwrap();

Expand Down Expand Up @@ -1136,8 +1148,11 @@ mod tests {
let fee_payer_token_account = Pubkey::new_unique();
let delegate = Pubkey::new_unique();

// Test with allow_approve = true (default)
setup_token2022_config();
// Test with allow_approve = true
setup_token2022_config_with_policy(FeePayerPolicy {
allow_approve: true,
..Default::default()
});

let validator = TransactionValidator::new(fee_payer).unwrap();

Expand Down
2 changes: 1 addition & 1 deletion docs/operators/deploy/sample/kora.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ allowed_spl_paid_tokens = [
disallowed_accounts = []

# Fee payer policy controls what actions the fee payer can perform
# All default to true for backward compatibility
# All default to false for security
[validation.fee_payer_policy]
allow_sol_transfers = true # Allow fee payer to be source in SOL transfers
allow_spl_transfers = true # Allow fee payer to be source in SPL token transfers
Expand Down