release: Feature Freeze for Audit

[dev-jodee]

…… (#221)

• feat: (PRO-203) Implement TurnkeyError handling and enhance PrivySigner error logging

• Added TurnkeyError enum for comprehensive error handling in TurnkeySigner.
• Updated sign and create_stamp methods to return TurnkeyError variants.
• Enhanced error logging in PrivySigner for API call failures, including status and response details.
• Refactored TurnkeySigner initialization to remove unnecessary error handling, improving clarity.
• Added tests for TurnkeyError display and conversion to KoraError.

• Update coverage badge [skip ci]

---

---

Important

Implemented TurnkeyError handling in TurnkeySigner and enhanced PrivySigner error logging, with added tests and coverage update.

• Error Handling:
  • Introduced TurnkeyError enum in types.rs for detailed error handling in TurnkeySigner.
  • Updated sign() and create_stamp() in signer.rs to return TurnkeyError variants.
  • Enhanced error logging in PrivySigner for API call failures in signer.rs.
• Refactoring:
  • Removed unnecessary error handling in TurnkeySigner initialization in config.rs.
• Testing:
  • Added tests for TurnkeyError display and conversion to KoraError in types.rs.
  • Added tests for error handling in signer.rs.
• Misc:
  • Updated coverage badge in coverage.json.

^{This description was created by for 178fa5a. You can customize this summary. It will automatically update as commits are pushed.}

📊 Unit Test Coverage

Unit Test Coverage: 80.8%

View Detailed Coverage Report

[linear]

PRO-203 Turnkey/privy: graceful error handling

[dev-jodee]

Release branch to accumulate code changes until the feature freeze is done

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to 178fa5a in 1 minute and 45 seconds. Click for details.

• Reviewed 442 lines of code in 7 files
• Skipped 0 files when reviewing.
• Skipped posting 6 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. crates/lib/src/signer/turnkey/signer.rs:115

• Draft comment:
  Avoid using unwrap() when converting signature bytes; use proper error propagation instead of try_into().
• Reason this comment was not posted:
  Comment was on unchanged code.

2. crates/lib/src/signer/turnkey/signer.rs:130

• Draft comment:
  Avoid unwrap() on the result of bytes_to_hex in create_stamp; propagate the error instead.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

3. crates/lib/src/signer/turnkey/types.rs:116

• Draft comment:
  TurnkeyError conversion to KoraError uses to_string(); consider preserving more context if needed.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% While the comment raises a valid point about error context preservation, it's speculative ("if needed") and doesn't provide concrete guidance. The test demonstrates the current behavior is intentional - wrapping the error message in a SigningError variant. Without seeing KoraError's definition and understanding the broader error handling strategy, we can't be certain this is actually a problem. The comment could be pointing to a legitimate architectural concern about error handling. Maybe there are cases where preserving the original error type would be valuable for error handling upstream. However, the current implementation appears intentional based on the test, and without more context about KoraError and the codebase's error handling strategy, this comment is too speculative to be actionable. The comment should be removed as it's speculative ("if needed") and requires broader context about error handling strategy to determine if it's actually an issue.

4. crates/lib/src/validator/transaction_validator.rs:49

• Draft comment:
  When converting program IDs from config, consider adding more context to errors for easier debugging.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

5. crates/lib/src/validator/transaction_validator.rs:178

• Draft comment:
  The closure 'check_if_allowed' is clear, but consider a more descriptive name (e.g. 'validate_source_account') to clarify its purpose.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

6. crates/lib/src/validator/transaction_validator.rs:321

• Draft comment:
  Tests rely on global config changes; ensure isolation if tests run concurrently. The use of #[serial] helps, but consider using dedicated config instances.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_e6HWmCt3LneL2fyG

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[github-actions]

📊 TypeScript Coverage Report

Coverage: 81.7%

View detailed report

Coverage artifacts have been uploaded to this workflow run.
View Artifacts

[ellipsis-dev]

⚠️ This PR is too big for Ellipsis, but support for larger PRs is coming soon. If you want us to prioritize this feature, let us know at help@ellipsis.dev

---

Generated with ❤️ by ellipsis.dev