chore: Update dependencies and refactor token interfaces (update to v…#242
Merged
dev-jodee merged 2 commits intorelease/feature-freeze-for-auditfrom Oct 28, 2025
Merged
Conversation
…3 for sdks) - Upgraded `agave-feature-set` and `agave-reserved-account-keys` to version 3.0.8 in `Cargo.lock`. - Updated various Solana SDK dependencies to version 3.0.x for improved compatibility and features. - Refactored token-related imports to use the new `spl_token_interface` and `spl_token_2022_interface` for better modularity. - Removed outdated dependencies and adjusted related code to ensure consistency across the codebase. - Enhanced test cases to reflect changes in token interface usage and ensure proper functionality.
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 77ea6d0 in 4 minutes and 30 seconds. Click for details.
- Reviewed
7748lines of code in35files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. tests/src/common/lookup_tables.rs:117
- Draft comment:
Consider adding a timeout or a maximum iteration limit in the slot polling loop to avoid potential infinite waiting if the slot never advances as required. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. tests/tokens/token_2022_extensions_test.rs:115
- Draft comment:
When asserting error messages, use proper formatting (e.g. via format!) to include the actual error details instead of literal placeholders like '{error}'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. tests/src/common/transaction.rs:609
- Draft comment:
The signing loop uses insecure_clone for signers. Ensure this approach is acceptable for tests and does not inadvertently mask real signature issues. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
Workflow ID: wflow_LINelxOl52PW12Ri
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed fd5ced6 in 8 minutes and 21 seconds. Click for details.
- Reviewed
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. crates/lib/src/rpc_server/method/transfer_transaction.rs:155
- Draft comment:
Import update: Addedstate::update_configimport for tests. Ensure this grouping is consistent with the project's import style. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_jL2rzrKnn855KcpR
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…3 for sdks)
agave-feature-setandagave-reserved-account-keysto version 3.0.8 inCargo.lock.spl_token_interfaceandspl_token_2022_interfacefor better modularity.Important
Update dependencies to version 3.x and refactor token interfaces for improved modularity and compatibility.
agave-feature-setandagave-reserved-account-keysto version 3.0.8 inCargo.lock.Cargo.tomlandCargo.lock.spl_token_interfaceandspl_token_2022_interface.This description was created by
for fd5ced6. You can customize this summary. It will automatically update as commits are pushed.
📊 Unit Test Coverage
Unit Test Coverage: 80.2%
View Detailed Coverage Report