bgufix: Update uncompile_instructions to prevent index out of bounds

[dev-jodee]

• Modified TransactionUtil::new_unsigned_versioned_transaction_resolved to return a Result type, ensuring proper error handling.
• Updated various test cases and transaction validation logic to unwrap results, improving robustness and clarity in error management.
• Introduced a new utility function get_account_key_required in IxUtils for safer account key retrieval, enhancing error reporting for missing keys.

---

Important

Improves error handling in transaction processing by returning Result in TransactionUtil::new_unsigned_versioned_transaction_resolved and adding IxUtils::get_account_key_required for safer account key retrieval.

• Behavior:
  • TransactionUtil::new_unsigned_versioned_transaction_resolved now returns Result, improving error handling.
  • Updated test cases in fee.rs, transfer_transaction.rs, and transaction_validator.rs to unwrap results, enhancing error management.
• Utilities:
  • Added IxUtils::get_account_key_required for safer account key retrieval, improving error reporting for missing keys.
• Functions:
  • Modified IxUtils::uncompile_instructions to return Result, ensuring robust error handling.

^{This description was created by for a610995. You can customize this summary. It will automatically update as commits are pushed.}

📊 Unit Test Coverage

Unit Test Coverage: 80.8%

View Detailed Coverage Report

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to a610995 in 1 minute and 5 seconds. Click for details.

• Reviewed 1000 lines of code in 6 files
• Skipped 0 files when reviewing.
• Skipped posting 4 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. crates/lib/src/validator/transaction_validator.rs:364

• Draft comment:
  Consider caching the config value in validate_strict_pricing_with_fee instead of calling get_config() again. This could improve performance by avoiding redundant config fetches.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

2. crates/lib/src/validator/transaction_validator.rs:311

• Draft comment:
  The inner loop in validate_disallowed_accounts iterates over each account in every instruction. Consider using a hash set for disallowed accounts to improve lookup performance if the number of accounts is large.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

3. crates/lib/src/validator/transaction_validator.rs:149

• Draft comment:
  In validate_programs, consider providing additional context in the error message (e.g. which instruction or its index) to aid debugging when a program is not allowed.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

4. crates/lib/src/validator/transaction_validator.rs:170

• Draft comment:
  Ensure that the macros used (validate_system! and validate_spl!) handle all edge cases. A code review of these macro definitions (if not already covered) is recommended to avoid unexpected behavior.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_h3kMO3alCZHfjNrS

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}