chore: docs updates#246
Merged
amilz merged 2 commits intorelease/feature-freeze-for-auditfrom Oct 31, 2025
Merged
Conversation
update based on using the solana signers crate closes PRO-513
- update CLAUDE.md - update CONFIGURATION.md - update FEES.md - update x402 guide closes PRO-501
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to aba1a99 in 5 minutes and 16 seconds. Click for details.
- Reviewed
1170lines of code in5files - Skipped
0files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. CLAUDE.md:415
- Draft comment:
There is a potential confusion: the intro states that fee payer policy defaults are set to false for security, yet the implementation details mention that Default implementations set fields to true for backward compatibility. Clarify this discrepancy. - Reason this comment was not posted:
Comment was on unchanged code.
2. docs/contributors/ADDING_SIGNERS.md:68
- Draft comment:
Ensure that the naming (e.g. 'YourService') in the SignerTypeConfig variant and related configuration struct is consistent with the implementation in the solana-signers crate. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
3. docs/operators/CONFIGURATION.md:284
- Draft comment:
The updated fee payer policy breakdown is very detailed. Double-check that all keys (system, system.nonce, spl_token, token_2022) exactly match the implementation in the code. - Reason this comment was not posted:
Confidence changes required:30%<= threshold50%None
4. docs/operators/FEES.md:101
- Draft comment:
Verify that the expected security warning text for fixed pricing (with system.allow_transfer=true) is consistent with the implementation and other documentation sections. - Reason this comment was not posted:
Confidence changes required:40%<= threshold50%None
5. docs/x402/demo/X402_DEMO_GUIDE.md:232
- Draft comment:
The demo setup is clear. Confirm that the instructions for starting Kora and the signers configuration align with the updated fee payer policy and signer docs. - Reason this comment was not posted:
Confidence changes required:30%<= threshold50%None
Workflow ID: wflow_17MpRCMZb4lGEG4g
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update docs based on a few breaking changes related to #236 and #231
closes PRO-513, PRO-501
Important
Update documentation for fee payer policy controls and signer integration in Kora.
CLAUDE.md,CONFIGURATION.md,FEES.md,X402_DEMO_GUIDE.md: Introduce granular controls for fee payer actions, organized by program type (System, SPL Token, Token-2022).falsefor security, with detailed descriptions of each control.ADDING_SIGNERS.md: Detailed step-by-step guide for adding new signers to Kora, including configuration, validation, and testing.solana-signerscrate and Kora configuration.This description was created by
for aba1a99. You can customize this summary. It will automatically update as commits are pushed.