ci(release): allow publish flow on hotfix branches#405
Conversation
Permit release preparation and publish workflows from hotfix/* in addition to main, so tag-based hotfix branches can publish patch releases without merging back first.
📊 TypeScript Coverage ReportCoverage: 33.1% View detailed reportCoverage artifacts have been uploaded to this workflow run. |
Greptile SummaryThis PR extends the release publishing pipeline to support Confidence Score: 5/5Safe to merge — all publish guards are correctly updated; remaining findings are minor style/consistency issues that do not affect security or correctness for standard single-level hotfix branch names. Both P2 findings (wildcard inconsistency in the trigger filter and a slightly misleading echo message) are cosmetic in practice: the hotfix recipe always produces single-level hotfix/ branches so the hotfix/** vs hotfix/* mismatch will never be hit in normal usage, and the echo message is non-functional. No P0/P1 issues found. .github/workflows/docker-publish.yml — review the hotfix/** trigger filter vs hotfix/* guard inconsistency. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Developer on hotfix/* branch] --> B[just release]
B --> C{Branch guard in justfile}
C -- main or hotfix/* --> D[Bump version, update CHANGELOG]
C -- other --> E[❌ Exit with error]
D --> F[git push origin HEAD]
F --> G[Manually dispatch Publish Rust Crates]
G --> H{rust-publish guard refs/heads/main or refs/heads/hotfix/*}
H -- allowed --> I[Publish to crates.io, Create GitHub Release, Push git tags]
H -- other --> J[❌ Exit with error]
I --> K[workflow_run triggers docker-publish on main or hotfix/**]
K --> L{docker-publish guard main or hotfix/*}
L -- allowed --> M[Build & Push Docker image, Update GitHub Release]
L -- other --> N[❌ Exit with error]
F --> O[Manually dispatch Publish TypeScript SDK]
O --> P{typescript guard refs/heads/main or refs/heads/hotfix/*}
P -- allowed --> Q[Publish to npm, Create GitHub Release]
P -- other --> R[❌ Exit with error]
M --> S[Merge hotfix branch back to main]
Q --> S
|
Align docker hotfix workflow_run pattern with runtime guard and make release recipe next-step guidance branch-aware for hotfix branches.
Summary
just releaseonmainandhotfix/*hotfix/*workflow_runand manual dispatch fromhotfix/*Test Plan
just --summarygit diff --check📊 Unit Test Coverage
Unit Test Coverage: 84.0%
View Detailed Coverage Report