Add transfer command

[ngundotra]

Works for stablecoin and arcade-token!

---

Important

Adds a new transfer command to the CLI for transferring tokens, with support for stablecoin and arcade-token, and integrates it into the main program.

• New Command:
  • Adds transferCommand in transfer.ts to transfer tokens, supporting stablecoin and arcade-token.
  • Handles creation of Associated Token Account (ATA) if needed.
  • Validates input amount and provides detailed error messages for common issues.
• Integration:
  • Integrates transferCommand into CLI in index.ts.
  • Adds transferCommand to the main program and command list.

^{This description was created by for 895a7a3. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to e06ba4f in 1 minute and 54 seconds. Click for details.

• Reviewed 237 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 4 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. packages/cli/src/commands/transfer.ts:143

• Draft comment:
  Consider explicitly using the public key (e.g. senderKeypair.publicKey) when a public key is expected (such as for feePayer or authority) to ensure clarity and type safety.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% Without seeing the type definitions for createTransaction and loadKeypair, I can't be 100% certain that using senderKeypair directly is incorrect. The code seems to follow a consistent pattern of using the keypair object directly. The fact that it compiles and the same pattern is used in multiple places suggests this might be the intended usage. I don't have access to the type definitions from the gill library to verify if feePayer actually expects a PublicKey type. The comment could be correct about improving type safety. However, without clear evidence that this is incorrect or seeing the type definitions, suggesting this change could introduce inconsistency with how keypairs are used elsewhere in the code. Since we don't have strong evidence that the current code is problematic or that the suggested change would be an improvement, we should err on the side of removing the comment.

2. packages/cli/src/commands/transfer.ts:208

• Draft comment:
  Instead of calling process.exit(1) directly in the catch block, consider setting process.exitCode to allow for any asynchronous cleanup or further error handling.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

3. packages/cli/src/commands/transfer.ts:181

• Draft comment:
  Clarify and document the purpose of the 'wasOwnerAddress' property in recipientTokenAccountInfo. Its significance (e.g. indicating that an ATA was created) should be made explicit for maintainability.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

4. packages/cli/src/index.ts:33

• Draft comment:
  Ensure that the newly added transferCommand correctly inherits and processes global options (such as --rpc-url and --keypair) similar to other commands.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_QKaShcjEKdYo4zXT

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed 895a7a3 in 36 seconds. Click for details.

• Reviewed 34 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 3 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. packages/cli/src/commands/transfer.ts:55

• Draft comment:
  Concise formatting for the recipient required option improves readability. Ensure consistent style across options.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

2. packages/cli/src/commands/transfer.ts:175

• Draft comment:
  Refactored logging for 'Tokens transferred successfully' into one line for clarity.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

3. packages/cli/src/commands/transfer.ts:207

• Draft comment:
  Added missing newline at end of file, which is a good practice for file formatting.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_BpSCLNyhSuGm3ATg

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}