Merged
Conversation
Contributor
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to d28637c in 2 minutes and 10 seconds. Click for details.
- Reviewed
447lines of code in5files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. package.json:17
- Draft comment:
New 'precommit' and 'check' scripts look useful; ensure their command ordering matches your intended workflow. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. packages/sdk/src/administration/__tests__/updateAuthority.test.ts:21
- Draft comment:
Tests comprehensively cover both 'Metadata' and standard authority roles. Verify that using AuthorityType[authorityType] (line 77) reliably gives the expected string. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to verify that a specific line of code behaves as expected. This falls under the category of asking the author to double-check or ensure behavior, which is against the rules. Therefore, this comment should be removed.
Workflow ID: wflow_fkyI9bzUXmmaqz6j
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 36b97e0 in 43 seconds. Click for details.
- Reviewed
46lines of code in2files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/sdk/src/administration/updateAuthority.ts:89
- Draft comment:
Explicitly passing an object literal to getUpdateAuthorityInstructions clarifies which parameters are used. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. packages/sdk/src/transactionUtil.ts:25
- Draft comment:
Inlining the getBase58Decoder call makes the code more concise without affecting readability. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. packages/sdk/src/transactionUtil.ts:44
- Draft comment:
Inlining the getBase64Decoder call improves conciseness while maintaining clarity. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_UgrdoDJnwM25Famh
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Token Authority Management Functions
Summary
This PR introduces a new administration module to the SDK with functions for updating token authorities on Solana Token-2022 program. The module provides a unified interface for updating both standard token authorities (mint, freeze, etc.) and metadata authorities.
🆕 What's Added
New Module:
packages/sdk/src/administration/Core Functions:
getUpdateAuthorityInstructions- Creates instructions to update token authoritiesgetUpdateAuthorityTransaction- Creates complete transactions for authority updatesKey Features:
getUpdateTokenMetadataUpdateAuthorityInstructionAuthority Types Supported
Testing
Comprehensive test suite with 28 test cases:
gill/programs/tokenimplementations📝 Usage Examples
Important
Add new module for managing token authorities in Solana Token-2022 program with comprehensive testing and utility functions.
packages/sdk/src/administration/getUpdateAuthorityInstructions: Creates instructions for updating token authorities.getUpdateAuthorityTransaction: Creates transactions for authority updates.updateAuthority.test.tsfor authority types, metadata, edge cases, and validation.gill/programs/tokenimplementations.transactionUtil.ts: Functions to convert transactions to base58 and base64 encoded strings.precommitandcheckscripts inpackage.json.This description was created by
for 36b97e0. You can customize this summary. It will automatically update as commits are pushed.