Add CLI Command for Creating Arcade Tokens#9
Merged
Conversation
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 140ac95 in 1 minute and 44 seconds. Click for details.
- Reviewed
264lines of code in4files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/cli/src/commands/create/arcade-token.ts:80
- Draft comment:
Confirm that enforcing decimals between 0 and 9 is intentional for arcade tokens. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This comment violates several rules. It's asking for confirmation/verification rather than pointing out a clear issue. It starts with "Confirm that..." which is explicitly called out as a red flag in the rules. Without seeing the SDK implementation or arcade token spec, we can't definitively say if this range is wrong. Maybe there's a legitimate concern about the decimal range being too restrictive compared to normal tokens? The comment could be highlighting a real architectural issue. Even if there is a legitimate concern, the comment should state it directly rather than asking for confirmation. Additionally, we don't have enough context about arcade token requirements to judge if this range is incorrect. The comment should be deleted as it violates the rule against asking for confirmations and doesn't clearly identify an issue that needs fixing.
2. packages/cli/src/commands/create/arcade-token.ts:86
- Draft comment:
Defaulting authority options to the signer (mintAuthority) is clear; ensure documentation reflects these fallbacks. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
3. packages/cli/src/commands/create/stablecoin.ts:86
- Draft comment:
Verify that the stablecoin decimals validation (0-9) meets protocol expectations, similar to arcade tokens. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. packages/sdk/src/templates/arcadeToken.ts:55
- Draft comment:
Using createNoopSigner for mint and feePayer conversion is pragmatic; double-check that it aligns with security and signing requirements in production. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to double-check if the use of createNoopSigner aligns with security and signing requirements in production. This violates the rule against asking the author to double-check things. The comment does not provide a specific suggestion or point out a specific issue with the code.
Workflow ID: wflow_tjKTRh8UUBIlTs9M
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CLI Command for Creating Arcade Tokens
Overview
This PR adds a new CLI command
mosaic create arcade-tokenthat enables developers to easily create arcade tokens with gaming-specific Token-2022 extensions directly from the command line.What's New
mosaic create arcade-tokenwith comprehensive options for token configurationFeatures
The new command creates tokens with the following extensions enabled by default:
CLI Usage
Changes Made
New CLI Command (
packages/cli/src/commands/create/arcade-token.ts)SDK Template Improvements (
packages/sdk/src/templates/arcadeToken.ts)TransactionSignersupportCLI Integration (
packages/cli/src/index.ts)Target Use Cases
Note for Users
Important
Adds a new CLI command for creating arcade tokens with Token-2022 extensions, improves SDK integration, and updates CLI to include the new command.
mosaic create arcade-tokeninarcade-token.tsfor creating arcade tokens with Token-2022 extensions.createArcadeTokenInitTransactioninarcadeToken.tswith better type safety and transaction handling.TransactionSignerfor mint and fee payer.createArcadeTokenCommandtoindex.tsunder the create command group.This description was created by
for 140ac95. You can customize this summary. It will automatically update as commits are pushed.