Skip to content

fix: check needsUpdate flag before showing update available warning #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ss251 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: check needsUpdate flag before showing update available warning #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ff434d
fix: check needsUpdate flag before showing update available warning
ss251 Jan 18, 2026
cd25c2d
chore: add changeset
ss251 Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-needs-update-check.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"mucho": patch
---

Fix false "update available" warnings by checking the needsUpdate flag instead of just the existence of the updateAvailable object.
10 changes: 5 additions & 5 deletions src/lib/install.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ export async function installAnchorVersionManager({
let installedVersion = await installedToolVersion("avm");
if (installedVersion) {
let message = `avm ${installedVersion} is already installed`;
if (updateAvailable) {
if (updateAvailable?.needsUpdate) {
message = picocolors.yellow(message + ` - update available`);
}
// todo: do we want to help people update avm?
Expand Down Expand Up @@ -316,7 +316,7 @@ export async function installAnchorUsingAvm({

if (installedVersion) {
let message = `anchor ${installedVersion} is already installed`;
if (updateAvailable) {
if (updateAvailable?.needsUpdate) {
message = picocolors.yellow(
message + ` - v${updateAvailable.latest} available`,
);
Expand Down Expand Up @@ -442,7 +442,7 @@ export async function installTrident({
let installedVersion = await installedToolVersion("trident");
if (installedVersion) {
let message = `trident ${installedVersion} is already installed`;
if (updateAvailable) {
if (updateAvailable?.needsUpdate) {
message = picocolors.yellow(
message + ` - ${updateAvailable.latest} available`,
);
Expand Down Expand Up @@ -506,7 +506,7 @@ export async function installZest({
let installedVersion = await installedToolVersion("zest");
if (installedVersion) {
let message = `zest ${installedVersion} is already installed`;
if (updateAvailable) {
if (updateAvailable?.needsUpdate) {
message = picocolors.yellow(message + ` - update available`);
}
spinner.info(message);
Expand Down Expand Up @@ -659,7 +659,7 @@ export async function installSolanaVerify({
let installedVersion = await installedToolVersion("verify");
if (installedVersion) {
let message = `solana-verify ${installedVersion} is already installed`;
if (updateAvailable) {
if (updateAvailable?.needsUpdate) {
message = picocolors.yellow(
message + ` - ${updateAvailable.latest} available`,
);
Expand Down