Skip to content

ci: fix npm publish workflow for pnpm workspace#291

Merged
amilz merged 3 commits intomainfrom
fix/npm-publish-workflow
Mar 27, 2026
Merged

ci: fix npm publish workflow for pnpm workspace#291
amilz merged 3 commits intomainfrom
fix/npm-publish-workflow

Conversation

@amilz
Copy link
Copy Markdown
Collaborator

@amilz amilz commented Mar 27, 2026

Summary

  • Add pnpm version: 10 to action-setup (same fix as feat! migrate @solana/pay to @solana/kit #288)
  • Change default working-directory to ./typescript workspace root so pnpm install finds the lockfile
  • Fix cache key to hash typescript/pnpm-lock.yaml instead of the deleted core/pnpm-lock.yaml
  • Use --filter @solana/pay for build/typecheck, explicit working-directory for pack/publish steps

Test plan

  • Trigger publish workflow (dry run) to verify pnpm installs and builds correctly

- Add pnpm version to action-setup
- Change default working-directory to typescript/ workspace root
- Fix cache key to point to typescript/pnpm-lock.yaml
- Use --filter for build/typecheck, explicit working-directory for pack/publish
@amilz amilz self-assigned this Mar 27, 2026
@amilz amilz requested a review from lgalabru March 27, 2026 16:26
Copy link
Copy Markdown
Collaborator

@lgalabru lgalabru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amilz!

@amilz amilz merged commit 9ee4a1e into main Mar 27, 2026
4 checks passed
@amilz amilz deleted the fix/npm-publish-workflow branch March 27, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants