Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…for dynamic avatar source resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SEO metadata handling and root SEO assets were duplicated across apps. That duplication made it easy for canonical tags, alternates, social metadata, icons, manifests, and feed metadata to drift apart over time.
This PR centralizes that logic so the apps generate SEO metadata from a shared resolver and generate root public SEO assets from a single source.
What Changed
Shared SEO package
packages/seofavicon.svgfavicon.pngfavicon.icoapple-touch-icon.pngicon-192.pngicon-512.pngsite.webmanifestApp integrations
apps/webnow uses the shared resolver for site metadataapps/docsnow uses the shared resolver for base metadata and MDX page metadataapps/medianow uses the shared resolver for layout metadata, listing metadata, article metadata, podcast metadata, and RSS/favicon referencesapps/breakpointnow uses the shared resolver for base metadataapps/acceleratenow uses generated root SEO assets and manifest paths consistentlyRouting / alternates
packages/i18nso canonical and hreflang URLs are built consistently for root and nested routesLLM / public content outputs
llms.txtoutputs forapps/webTests
Why This Approach
Manual Review
Setup
Run this once before manual review so generated root SEO assets exist locally:
Primary review path
http://localhost:3000/validators/developers/ecosystem/deor/ja/validatorsWhat to check on
localhost:3000/rather than malformed double-slash variants/favicon.ico/favicon.png/favicon.svg/apple-touch-icon.png/site.webmanifestog:titleog:descriptionog:imagetwitter:titletwitter:descriptiontwitter:imageSecondary review paths
If you want broader confidence, also spot check:
http://localhost:3003http://localhost:3002/news/podcastshttp://localhost:3005http://localhost:3004Expected review outcome
You should see no visual or routing regressions. The intended change is in metadata generation and SEO asset generation, not in user-facing page layout or copy.
Notes For Reviewers
icon-192.pngandicon-512.pngchanges are generated output from the new shared asset pipelineprebuild, so local review should start withpnpm seo:sync-publicbuildscript, which triggers each app'sprebuildand generates these files during deploymentValidation
pnpm seo:sync-publicpnpm --filter @workspace/seo testpnpm --filter @workspace/i18n test -- routing