feat: add PDA size derivation in anchor#38
Open
unive3sal wants to merge 1 commit intosolana-foundation:mainfrom
Open
feat: add PDA size derivation in anchor#38unive3sal wants to merge 1 commit intosolana-foundation:mainfrom
unive3sal wants to merge 1 commit intosolana-foundation:mainfrom
Conversation
MicaiahReid
suggested changes
Mar 19, 2026
skill/references/programs-anchor.md
Outdated
|
|
||
| ### Account Size | ||
|
|
||
| Use `#[derive(InitSpace)]` to derive PDA data size instead of calculate it manually. |
Contributor
There was a problem hiding this comment.
Suggested change
| Use `#[derive(InitSpace)]` to derive PDA data size instead of calculate it manually. | |
| Use `#[derive(InitSpace)]` to derive PDA data size instead of calculating it manually. |
Contributor
Author
|
I've updated according to your comments |
MicaiahReid
suggested changes
Mar 20, 2026
Contributor
MicaiahReid
left a comment
There was a problem hiding this comment.
Looking better, almost there! Thank you @unive3sal!
Contributor
Author
|
Hi @MicaiahReid Thanks for your comments. I've updated the commit. |
MicaiahReid
approved these changes
Mar 23, 2026
Contributor
MicaiahReid
left a comment
There was a problem hiding this comment.
LGTM, thanks @unive3sal!
use InitSpace macro to derive PDA account size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Would you please kindly review this change?
I raise this PR because I met this problem during my development. Here is the commit for your reference:
PinkPlants/pactum@9acef99#diff-525ff2c25561ab1bb4a21349fa32321ac40f9b40dd6f2fc5a36cd9e6a37046b6