fix: panics in non-Must* functions#374
Merged
HealthyBuilder merged 1 commit intoApr 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SDK code uses
panic()in non-Must*functions, meaning any caller - including user application code - could have their process crash with no recovery path:Message.SetVersion()panicked on invalid version instead of returning an errorRegisterInstructionDecoder()panicked when a different decoder was already registered for the same program IDData.String()panicked when the zstd encoder pool returned an errorRegisterInstructionDecoder()had a TOCTOU race: the existence check and the registration were two separate locked operations, so a concurrent registration could be silently droppedSetProgramID()across 9 program packages calledMustRegisterInstructionDecoder, meaning public runtime API could panic the caller's processSummary of Changes
Must*functions with returningerrorMustRegisterInstructionDecoderforinit()use