fix: detect v0 tx version from AddressTableLookups in JSON#377
Closed
vukamecos wants to merge 1 commit into
Closed
fix: detect v0 tx version from AddressTableLookups in JSON#377vukamecos wants to merge 1 commit into
vukamecos wants to merge 1 commit into
Conversation
vukamecos
force-pushed
the
fix/issue-339-message-version
branch
from
cdb62b0 to
6997be0
Compare
Contributor
|
@vukamecos thank you for the contribution v0 transactions without lookups are still misclassified. a v0 transaction can have an empty |
Collaborator
|
hey @vukamecos thanks for your contribution! @sonicfromnewyoke has addressed this issue in #404 ? shall we close this PR? But really appreciate you flagging this issue. |
Contributor
yes, we can close. It should be already done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #339