Add changedSinceSlot on account fetch operations#392
Conversation
cloakd
changed the title
changedSinceSlot on account fetch operations
|
Updated to keep up with changes on base branch. |
sonicfromnewyoke
left a comment
sonicfromnewyoke
left a comment
There was a problem hiding this comment.
I really like this improvement, becase there are devs who use comercial RPCs.
the only what i'd like to ask you - adding some extra description on who supports those (like FluxRPC) fields
| Filters []RPCFilter `json:"filters,omitempty"` | ||
|
|
||
| // Return only the accounts that have changed since this slot | ||
| ChangedSinceSlot *uint64 `json:"changedSinceSlot,omitempty"` |
There was a problem hiding this comment.
the same description should be here, i believe
Co-authored-by: Sonic <sonic.from.new.yoke@gmail.com>
|
Sure, typically we dont over document when the field is self-explanatory but if its code guidelines happy to update |
|
@sonicfromnewyoke should be good to go now! |
commit-lint (used for the changelog) and golangci-lint (used for the code quality) are failing |
|
Thanks for your contribution! Looks great! kindly ping @cloakd on 2 failing check as Sonic mentioned |
3 participants
FluxRPC & Helius both offer
changedSinceSlotarg for account fetch calls - this significantly reduces the gPA data loads needed for keeping 3rd party services in sync as incremental sync can be done rather than fetching full account state data.Especially useful for large programs such as PumpFun (most RPCs disallow a full gPA on this program now)