fix(rpc): match ParsedTransactionMeta to TransactionMeta#409
Merged
HealthyBuilder merged 1 commit intoApr 23, 2026
Merged
Conversation
Agave returns the same UiTransactionStatusMeta shape on the wire for both binary and jsonParsed encodings — only the innerInstructions[].instructions[] shape differs (compiled vs parsed, via an untagged serde enum). Our Go split into TransactionMeta / ParsedTransactionMeta dropped five trailing fields on the parsed side when the type was originally written, so a jsonParsed tx silently loses Status, Rewards, LoadedAddresses, ReturnData, and ComputeUnitsConsumed on decode. Mirror those five fields onto ParsedTransactionMeta. No new types needed — LoadedAddresses / ReturnData / DeprecatedTransactionMetaStatus already live in this file, and the remaining two are plain types. Adds TestParsedTransactionMeta_Decode as a regression guard: a realistic jsonParsed meta fixture with every previously-missing field populated, asserting each round-trips cleanly. Closes solana-foundation#284
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
there are missing fields in
ParsedTransactionMetawhich present inTransactionMetaSolution
match fileds of both structs
closes #284