fix: handle websocket subscription error responses before result parsing#418
Open
tanmay4l wants to merge 1 commit into
Open
fix: handle websocket subscription error responses before result parsing#418tanmay4l wants to merge 1 commit into
tanmay4l wants to merge 1 commit into
Conversation
Contributor
sonicfromnewyoke
left a comment
sonicfromnewyoke
left a comment
There was a problem hiding this comment.
to me looks good, after some fixes of tests will be good to merge, i believe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a websocket bug where subscribe responses with an error field were not handled correctly.
Now we detect RPC errors first, close that subscription with the real error, and avoid mis-parsing result.
Also added a regression test for this exact case.