refactor(base58): replace mr-tron/base58 with in-tree long-division encoder#425
Merged
HealthyBuilder merged 1 commit intoMay 8, 2026
Conversation
Collaborator
|
LGTM — removing the mr-tron dependency makes sense |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
the
base58package's fast paths only covered 32/64-byte inputs, so every other length (instruction data, Base58.MarshalJSON, Data.String) had to go through the externalgithub.com/mr-tron/base58module - a needless dependency, and one with a latent buffer-sizing bug that panics on all-zero inputthis change pulls the long-division algorithm in-tree behind a unified
base58.Encodeentry point and drops the external dependencySummary of Changes
base58.Encode(buf []byte) stringdispatcher: 32/64-byte fast paths + vendored long-division fallback (encodeVariable) with the mr-tron buffer-sizing bug fixedmr-tron/base58module dependency; rewire all callers (Base58, Data, Hash, Signature, PublicKey, PrivateKey) tobase58.Encode