feat(ws): support dataSlice in ProgramSubscribe#434
Open
ozpool wants to merge 1 commit into
Open
Conversation
Add ProgramSubscribeOpts and ProgramSubscribeWithConfig to mirror the
optional configuration object the programSubscribe RPC method accepts,
including the missing dataSlice parameter. dataSlice asks the
validator to return only the requested slice of each notified
account's data field. For programSubscribe that's especially
important: every account owned by the program emits notifications, so
trimming the payload to the relevant header bytes (discriminators,
mint, owner, amount, etc.) avoids shipping the full account data on
every update.
The existing ProgramSubscribeWithOpts(programID, commitment, encoding,
filters) entry point delegates to the new opts form, so existing
callers are not affected.
Adds wire-shape tests covering: defaults, dataSlice JSON shape
({"offset": N, "length": N}), and dataSlice combined with filters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ProgramSubscribeOpts+ProgramSubscribeWithConfigto mirror the optional configuration object theprogramSubscribeRPC method accepts, including the missingdataSliceparameter.dataSliceasks the validator to return only the requested{offset, length}slice of each notified account's data field. For programSubscribe that's especially important: every account owned by the program emits notifications, so trimming the payload to the relevant header bytes (discriminators, mint, owner, amount, etc.) avoids shipping full account data on every update.What changed
ProgramSubscribeOpts { Commitment, Encoding, Filters, DataSlice }.ProgramSubscribeWithConfig(programID, opts)carries the full opts object through to the request body.ProgramSubscribeWithOpts(programID, commitment, encoding, filters)is preserved by delegating to the new opts form, andProgramSubscribe(programID, commitment)is unchanged.Test plan
go build ./...go test ./...programSubscribe_test.goasserts: defaults,dataSliceJSON shape{\"offset\":N,\"length\":N}, and the combineddataSlice+filterspath