SIMD-0201: Create a Cluster Sysvar #201
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blockiosaurus
changed the title
buffalojoec
reviewed
Nov 26, 2024
Comment on lines
+44
to
+54
| #[repr(C)] | ||
| pub struct ClusterDetails { | ||
| /// The genesis hash for the cluster, guaranteed for mainnet but | ||
| /// possibly variable for other cluster types. | ||
| pub genesis_hash: Hash, | ||
| /// A named tag for the SVM chain on which the program is executing. | ||
| pub blockchain: String, | ||
| /// Cluster Type | ||
| pub cluster_type: ClusterType, | ||
| } | ||
| ``` |
Contributor
There was a problem hiding this comment.
Personally I would advocate for a static layout here. Can we accomplish the stated goal with IDs? Something like:
genesis_hash: [u8; 32] // (Hash)
blockchain: [u8; 8]
cluster: [u8; 8]
I guess that introduces the problem of where to "register" chain IDs, but I think we were going to have that problem anyway, right?
Contributor
Author
There was a problem hiding this comment.
I think it'd be nice to have the cluster identifier be typed but that could easily be accomplished with helpers in the SDK.
I think the static type makes sense. The chain ID is really for continuity for Devnet resets and debugging so relying on an external registry also works!
|
This would definitely be nice to have |
Collaborator
|
stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.