spec for TLV Extensions #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@gregcusack wdyt? |
Author
|
Some agave-specific context on this one anza-xyz/agave#6082 |
Author
Author
|
Who is responsible for this doc anyway? @gregcusack maybe you can task some of your contractors to look at it and make sure it is correct? We clearly do not need 5 specs for gossip which are all wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing Extensions mechanism in Gossip ContactInfo message was not well documented, this PR provides the specification for how it would be able to work in practice. Due to an error in the specification, it could not actually fulfill its role.
This change does not affect consensus, and does not require support by clients beyond copying the original message's bytes.