fuzz: generate firedancer-compatible fixtures #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
force-pushed
the
mollusk-firedancer-fixtures
branch
3 times, most recently
from
775acb0 to
707e33c
Compare
buffalojoec
force-pushed
the
mollusk-firedancer-fixtures
branch
from
707e33c to
77774f5
Compare
joncinque
approved these changes
Nov 25, 2024
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
This is a "I blindly trust you" approval 😅
Contributor
Author
Appreciated! Fwiw, I updated the protobufs in Mollusk and then ran them through the FD tooling here, so I know they work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Mollusk is capable of generating fuzz/conformance fixtures from defined unit tests. However, the protobufs used to create these fixtures were from an earlier version of Protosol - Firedancer's protobuf repository. In order to be able to use Mollusk-generated fixtures with Firedancer's conformance tooling, we need to use the new protobuf layouts.
Summary of Changes
Use Mollusk's new
fuzz-fdfeature, which generates Firedancer-compatible fuzz fixtures from unit tests.