Update client to match builtin offchain API #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note: depends on codama-idl/codama#510 @joncinque Feel free to take a look in the meantime and let me know if this seems sensible. CU reduction! 💪🏼 |
buffalojoec
commented
Mar 17, 2025
joncinque
reviewed
Mar 17, 2025
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks great overall! Mostly small stuff
joncinque
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the removal of the Config builtin from the Agave monorepo, we need to update the generated client to support some of the original builtin's API, to minimize friction during builtin eviction.
This PR basically extracts everything the program's processor does not need into the client. This way, Agave can simply import the client to work with Config accounts and the Config program.
It also drops one unnecessary free function and one unnecessary associated function on
ConfigKeys.