Skip to content

Conversation

@buffalojoec
Copy link
Contributor

@buffalojoec buffalojoec commented May 6, 2025

Takes the exact same changes as solana-program/system#51 and applies them to the Config program repo.

@buffalojoec buffalojoec changed the title overhaul ci with makefile overhaul CI with Makefile May 6, 2025
@buffalojoec buffalojoec force-pushed the makefile-ci branch 6 times, most recently from f702d6c to d91040a Compare May 7, 2025 04:30
@buffalojoec buffalojoec marked this pull request as ready for review May 7, 2025 04:38
@buffalojoec buffalojoec requested a review from joncinque May 7, 2025 04:38
@buffalojoec
Copy link
Contributor Author

@joncinque this felt like the more exhausting but long-term better way to go about getting a publish script working to release the new interface crate. Lmk!

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments, looks good otherwise!

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of last things

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@joncinque
Copy link
Contributor

Since this PR renamed some of the CI steps, I had to disable them as required to merge. Once it lands, I'll update the required steps to include the new names.

@buffalojoec
Copy link
Contributor Author

Since this PR renamed some of the CI steps, I had to disable them as required to merge. Once it lands, I'll update the required steps to include the new names.

Do you have to always do this manually? That's kind of annoying. I was thinking they would fix themselves after this lands.

@buffalojoec buffalojoec merged commit 592429b into main May 17, 2025
12 checks passed
@buffalojoec buffalojoec deleted the makefile-ci branch May 17, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants