-
Notifications
You must be signed in to change notification settings - Fork 15
Make ListView friendlier to ? syntax
#166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
78b268f to
ec6a4b6
Compare
ec6a4b6 to
f24165f
Compare
buffalojoec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based. Gud fix. Just a few small things.
buffalojoec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Thanks for throwing in some extra variants.
|
Pinocchio will start using the same program error as the sdk soon, so I would prefer to stick with Edit: mainly because it's a huge hassle to upgrade everything when there's a breaking change to spl-pod, I would avoid it |
|
Oh! If those types are converging, then this is indeed not necessary. Will revert. |
At the moment,
ListViewis returningProgramErroreverywhere. This makes Pinnochio consumers required to map the error:The primary goal of this change is to enable the direct use of the
?operator in consuming code by returningPodSliceErrorinstead and implementingFromtraits to both program error types. After:Change type
Breaking change. Several returned err types have changed. Will require major version bump. Open to thoughts on how to handle this or if this is the right change in general.