interface: include onramp in deposit/withdraw #396
+21
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2501babe
force-pushed
the
onramp-in-builders
branch
from
ce2395e to
bf6dda6
Compare
2501babe
commented
Nov 5, 2025
Comment on lines
-198
to
+183
| // NOTE once deposit/withdraw require onramp, delete this block | ||
| if include_onramp && instruction_pubkey == accounts.pool { | ||
| if !remove_onramp && instruction_pubkey == accounts.pool { |
Member
Author
There was a problem hiding this comment.
i realized this comment is pointless because once they require onramp we have to get rid of everything involving remove_onramp
This was referenced Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after we deploy 3.0 on mainnet (edit: now done), land this. then we cut a new patch release of the program (to let downstream pick up the new instruction builders) and a new major release of the cli (to put out the improvements in #393 and get the new instruction builders in there immediately)
part of #387