Skip to content

Conversation

@lorisleiva
Copy link
Member

This PR updates Codama and its renderers to the latest versions.

It also uses the new Codama CLI to render the clients of the System program.

This PR updates Codama and its renderers to the latest versions.

It also uses the new Codama CLI to render the clients of the System program.
@lorisleiva lorisleiva marked this pull request as draft January 31, 2025 18:31
Comment on lines +22 to +23
solana-client = { version = "^2.1", optional = true }
solana-sdk = { version = "^2.1", optional = true }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we are currently having to use these crates instead of the more granular ones to stay compatible with clients using Solana below 2.1.

We have documented a way forward on the Codama Rust renderer here.

This comment was marked as spam.

@lorisleiva lorisleiva marked this pull request as ready for review February 3, 2025 14:57
@lorisleiva lorisleiva requested review from febo and joncinque February 3, 2025 14:57
@lorisleiva lorisleiva changed the title Update Codama to 1.2.2 and use Codama CLI Update Codama to 1.2.4 and use Codama CLI Feb 3, 2025
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for sharing!

Comment on lines +67 to +69
let accounts = rpc
.get_multiple_accounts(&addresses)
.map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e.to_string()))?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some RPCs meter the get_multiple_accounts call differently than the normal get_account_info, so it might be worth avoiding get_multiple_accounts for just one input

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good to know. This is something that would needs updating on the Rust renderer (was introduced in this PR). I made an issue for it.

This comment was marked as spam.

@lorisleiva lorisleiva merged commit c755dfa into main Feb 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants